Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ADTypeCheckContext method ambiguity #2299

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Aug 9, 2024

Should fix the issue in TuringLang/DynamicPPL.jl#638. I'm a bit bothered by way the method ambiguity did not come up in Turing's own CI, but only in DPPL's. Also, I think this will fix the issue, but might need to run DPPL's tests to see.

@devmotion
Copy link
Member

devmotion commented Aug 9, 2024

I guess these ambiguities arise from TuringLang/DynamicPPL.jl#636 which has not been released yet (and therefore currently they show only up in DynamicPPL CI but not in Turing).

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (803d2f5) to head (4ae44cb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
- Coverage   83.98%   82.47%   -1.51%     
==========================================
  Files          24       24              
  Lines        1617     1615       -2     
==========================================
- Hits         1358     1332      -26     
- Misses        259      283      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Aug 9, 2024

Pull Request Test Coverage Report for Build 10317898020

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 84.348%

Files with Coverage Reduction New Missed Lines %
src/mcmc/abstractmcmc.jl 2 90.91%
Totals Coverage Status
Change from base Build 10281463329: 0.0%
Covered Lines: 1358
Relevant Lines: 1610

💛 - Coveralls

@mhauru
Copy link
Member Author

mhauru commented Aug 9, 2024

Thanks @devmotion, that makes sense.

We seem to have an unfortunate case here where a PR that passed tests (#2291) was merged, and then immediately after merging tests on master started to fail (https://github.com/TuringLang/Turing.jl/actions/runs/10281463329/job/28451089388). That's still the failure in this PR too. It's a concurrency problem of some kind, only appears on multithreaded. Haven't dug into it yet.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhauru!

@mhauru
Copy link
Member Author

mhauru commented Aug 9, 2024

Merging this since the test failure is on master too and the loss of coverage seems unrelated, and this is holding up the DPPL PR. Need to get to the bottom of the test failure and how it slipped through in the first place though.

@mhauru mhauru merged commit 07cc40b into master Aug 9, 2024
58 of 60 checks passed
@mhauru mhauru deleted the mhauru/adtypecheckcontext branch August 9, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants